Re: [PATCH 21/32] bdev: Drop pointless invalidate_mapping_buffers() call
Christian Brauner <[email protected]> Wed, 4 Mar 2026 14:39:54 +0100
| Newsgroups | gmane.comp.file-systems.ext4,gmane.linux.file-systems,gmane.linux.kernel.mm,gmane.linux.kernel.aio.general,gmane.linux.block |
|---|---|
| Message-ID | <20260304-dachboden-minibar-620c6f7d69fc@brauner> |
On Tue, Mar 03, 2026 at 11:34:10AM +0100, Jan Kara wrote: > Nobody is calling mark_buffer_dirty_inode() with internal bdev inode and > it doesn't make sense for internal bdev inode to have any metadata > buffer heads. Just drop the pointless invalidate_mapping_buffers() call. s/invalidate_mapping_buffers/invalidate_inode_buffers/g? > > CC: Jens Axboe <[email protected]> > CC: [email protected] > Signed-off-by: Jan Kara <[email protected]> > --- > block/bdev.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/block/bdev.c b/block/bdev.c > index ed022f8c48c7..ad1660b6b324 100644 > --- a/block/bdev.c > +++ b/block/bdev.c > @@ -420,7 +420,6 @@ static void init_once(void *data) > static void bdev_evict_inode(struct inode *inode) > { > truncate_inode_pages_final(&inode->i_data); > - invalidate_inode_buffers(inode); /* is it needed here? */ > clear_inode(inode); > } > > -- > 2.51.0 >