Re: [PATCH 21/32] bdev: Drop pointless invalidate_mapping_buffers() call

On Wed 04-03-26 14:39:54, Christian Brauner wrote:
> On Tue, Mar 03, 2026 at 11:34:10AM +0100, Jan Kara wrote:
> > Nobody is calling mark_buffer_dirty_inode() with internal bdev inode and
> > it doesn't make sense for internal bdev inode to have any metadata
> > buffer heads. Just drop the pointless invalidate_mapping_buffers() call.
> 
> s/invalidate_mapping_buffers/invalidate_inode_buffers/g?

Thanks. Fixed.

								Honza

> 
> > 
> > CC: Jens Axboe <[email protected]>
> > CC: [email protected]
> > Signed-off-by: Jan Kara <[email protected]>
> > ---
> >  block/bdev.c | 1 -
> >  1 file changed, 1 deletion(-)
> > 
> > diff --git a/block/bdev.c b/block/bdev.c
> > index ed022f8c48c7..ad1660b6b324 100644
> > --- a/block/bdev.c
> > +++ b/block/bdev.c
> > @@ -420,7 +420,6 @@ static void init_once(void *data)
> >  static void bdev_evict_inode(struct inode *inode)
> >  {
> >  	truncate_inode_pages_final(&inode->i_data);
> > -	invalidate_inode_buffers(inode); /* is it needed here? */
> >  	clear_inode(inode);
> >  }
> >  
> > -- 
> > 2.51.0
> > 
-- 
Jan Kara <[email protected]>
SUSE Labs, CR

--
To unsubscribe, send a message with 'unsubscribe linux-aio' in
the body to [email protected].  For more info on Linux AIO,
see: http://www.kvack.org/aio/
Don't email: <a href=mailto:"[email protected]">[email protected]</a>