Re: [PATCH 14/42] fs: Rename generic_file_fsync() to simple_fsync()
Jan Kara <[email protected]> Fri, 27 Mar 2026 17:26:57 +0100
| Newsgroups | gmane.linux.kernel.aio.general,gmane.linux.file-systems,gmane.linux.block,gmane.comp.file-systems.ext4,gmane.linux.kernel.mm |
|---|---|
| Message-ID | <szke56tw43bq2wyv3rai3akrewxbpclbj3finajrwtubkzbgbz@zgj7cc7h2sr2> |
On Thu 26-03-26 23:22:23, Christoph Hellwig wrote: > > -extern int __generic_file_fsync(struct file *, loff_t, loff_t, int); > > -extern int generic_file_fsync(struct file *, loff_t, loff_t, int); > > +extern int simple_fsync_noflush(struct file *, loff_t, loff_t, int); > > +extern int simple_fsync(struct file *, loff_t, loff_t, int); > > Please drop the pointless externs, and maybe also add the parameter names > when you touch it. > > Otherwise looks good. I believe Christian has a patch from Jeff in his tree cleaning up the whole fs.h header in this way. Not sure how Christian ended up resolving the conflict but we can clean this up after the merge window if some externs are still left there. Honza -- Jan Kara <[email protected]> SUSE Labs, CR -- To unsubscribe, send a message with 'unsubscribe linux-aio' in the body to [email protected]. For more info on Linux AIO, see: http://www.kvack.org/aio/ Don't email: <a href=mailto:"[email protected]">[email protected]</a>