Re: [PATCH] block: split out a new blk_plug.h helper
Christoph Hellwig <[email protected]> Mon, 6 Jul 2026 11:54:07 +0200
| Newsgroups | gmane.linux.kernel.aio.general,gmane.linux.block,gmane.linux.file-systems,gmane.linux.kernel,gmane.linux.kernel.io-uring,gmane.linux.kernel.mm |
|---|---|
| Message-ID | <[email protected]> |
On Mon, Jul 06, 2026 at 04:04:48PM +0900, Damien Le Moal wrote: > > +#include <linux/sched.h> > > struct blk_plug_cb has a list_head. So maybe also add > > #include <linux/types.h> > > ? That already gets pulled in. > > + > > +struct blk_plug_cb; > > Maybe add "struct request;" here too ? No need for type forward declarations when the types are only used for pointers in structs (or as pointer variables). They are needed only when pointers to the type are used in prototypes. -- To unsubscribe, send a message with 'unsubscribe linux-aio' in the body to [email protected]. For more info on Linux AIO, see: http://www.kvack.org/aio/ Don't email: <a href=mailto:"[email protected]">[email protected]</a>