Re: [PATCH 2/4] vfs: fs/namei.c: remove LOOKUP_NO_XDEV check from handle_mounts
Al Viro <[email protected]>
| Newsgroups | gmane.linux.file-systems,gmane.linux.kernel.autofs |
|---|---|
| Message-ID | <20250817180057.GA222315@ZenIV> |
On Sun, Aug 17, 2025 at 05:15:11PM +0000, Askar Safin wrote: > This is preparation to RESOLVE_NO_XDEV fix in following commits. > No functional change intended > > Signed-off-by: Askar Safin <[email protected]> > --- > fs/namei.c | 6 ++---- > 1 file changed, 2 insertions(+), 4 deletions(-) > > diff --git a/fs/namei.c b/fs/namei.c > index 1e13d8e119a4..00f79559e135 100644 > --- a/fs/namei.c > +++ b/fs/namei.c > @@ -1635,10 +1635,8 @@ static inline int handle_mounts(struct nameidata *nd, struct dentry *dentry, > return -ECHILD; > } > ret = traverse_mounts(path, &jumped, &nd->total_link_count, nd->flags); > - if (jumped) { > - if (!unlikely(nd->flags & LOOKUP_NO_XDEV)) > - nd->state |= ND_JUMPED; > - } > + if (jumped) > + nd->state |= ND_JUMPED; I'd add something along the lines of "the only place that ever looks at ND_JUMPED in nd->state is complete_walk() and we are not going to reach it if handle_mounts() returns an error" to commit message.