Re: [PATCH v3 00/12] man2: document "new" mount API
Aleksa Sarai <cyphar-gVpy/LI/[email protected]> Mon, 18 Aug 2025 15:46:05 +1000
| Newsgroups | gmane.linux.kernel.api,gmane.linux.kernel.autofs,gmane.linux.file-systems,gmane.linux.kernel,gmane.linux.man |
|---|---|
| Message-ID | <2025-08-18.1755493208-minty-roomy-vessel-moisture-2LjJfF@cyphar.com> |
On 2025-08-17, Askar Safin <safinaskar-yBVup5oSL51Wk0Htik3J/[email protected]> wrote: > I just sent to fsdevel fix for that RESOLVE_NO_XDEV bug. Thanks, I've sent some review comments. > if (!(lookup_flags & (LOOKUP_PARENT | LOOKUP_DIRECTORY | > LOOKUP_OPEN | LOOKUP_CREATE | LOOKUP_AUTOMOUNT)) && > > We never return -EISDIR in this "if" if we are in non-final component > thanks to LOOKUP_PARENT here. We fall to finish_automount instead. Grr, I re-read this conditional a few times and I still misunderstood what it was doing. My bad. -- Aleksa Sarai Senior Software Engineer (Containers) SUSE Linux GmbH https://www.cyphar.com/
signature.asc
(application/pgp-signature, 265 B)
-----BEGIN PGP SIGNATURE----- iJEEABYKADkWIQS2TklVsp+j1GPyqQYol/rSt+lEbwUCaKK+HRsUgAAAAAAEAA5t YW51MiwyLjUrMS4xMSwyLDIACgkQKJf60rfpRG/V6wD/YoQbj4tPRHlDjEHb/OQx ywcB7eDulYkzVyOOr83XOwgBAK2OMvD5MDyw+msA5wsI7g8wFAsL5ZDWA0Cn61OJ daYK =7p79 -----END PGP SIGNATURE-----