Re: [PATCH 59/61] iomap: update format string for u64 i_ino
"Darrick J. Wong via Linux-f2fs-devel" <[email protected]> Thu, 26 Feb 2026 08:21:15 -0800
| Newsgroups | gmane.linux.file-systems.f2fs,gmane.comp.video.dri.devel,gmane.linux.hams,gmane.comp.file-systems.ceph.devel,gmane.linux.kernel,gmane.linux.kernel.perf.user,gmane.linux.drivers.video-input-infrastructure,gmane.linux.kernel.cifs,gmane.comp.file-systems.nilfs.user,gmane.comp.file-systems.coda.general,gmane.linux.drivers.mtd,gmane.comp.freedesktop.amd-gfx,gmane.linux.kernel.autofs,gmane.linux.nfs,gmane.comp.file-systems.ext4,gmane.linux.kernel.mm,gmane.network.samba.internals,gmane.linux.file-systems,gmane.comp.file-systems.ecryptfs.general,gmane.linux.file-systems.union,gmane.linux.x25,gmane.comp.security.apparmor,gmane.linux.network,gmane.linux.kernel.lsm |
|---|---|
| Message-ID | <20260226162115.GG13829@frogsfrogsfrogs> |
On Thu, Feb 26, 2026 at 10:56:01AM -0500, Jeff Layton wrote: > Update format string from %lu to %llu for inode->i_ino now that > i_ino is u64 instead of unsigned long. > > Signed-off-by: Jeff Layton <[email protected]> Looks fine to me, though I'm a bit sad there's no xfs_inode::i_ino -> inode::i_ino conversion patch... ;) Reviewed-by: "Darrick J. Wong" <[email protected]> --D > --- > fs/iomap/ioend.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/fs/iomap/ioend.c b/fs/iomap/ioend.c > index 4d1ef8a2cee90b91591d387f8e1c3f75350c1da0..94d9a3c77bd68581d752fef4c16b88e1cb5f88da 100644 > --- a/fs/iomap/ioend.c > +++ b/fs/iomap/ioend.c > @@ -48,7 +48,7 @@ static u32 iomap_finish_ioend_buffered(struct iomap_ioend *ioend) > mapping_set_error(inode->i_mapping, ioend->io_error); > if (!bio_flagged(bio, BIO_QUIET)) { > pr_err_ratelimited( > -"%s: writeback error on inode %lu, offset %lld, sector %llu", > +"%s: writeback error on inode %llu, offset %lld, sector %llu", > inode->i_sb->s_id, inode->i_ino, > ioend->io_offset, ioend->io_sector); > } > > -- > 2.53.0 > >