Re: [PATCH v2 069/110] 9p: replace PRIino with %llu/%llx format strings

Christian Schoenebeck via Linux-f2fs-devel <[email protected]> Tue, 03 Mar 2026 13:12:51 +0100
Newsgroups gmane.linux.file-systems.f2fs,gmane.comp.video.dri.devel,gmane.linux.file-systems.union,gmane.linux.kernel.mm,gmane.linux.drivers.mtd,gmane.linux.kernel.cifs,gmane.comp.file-systems.nilfs.user,gmane.linux.x25,gmane.linux.bluez.kernel,gmane.comp.freedesktop.amd-gfx,gmane.comp.file-systems.coda.general,gmane.comp.file-systems.ext4,gmane.linux.kernel.bpf,gmane.comp.file-systems.ecryptfs.general,gmane.linux.kernel.autofs,gmane.comp.security.apparmor,gmane.linux.drivers.video-input-infrastructure,gmane.linux.can,gmane.linux.hams,gmane.comp.file-systems.ceph.devel,gmane.linux.nfs,gmane.linux.network,gmane.network.samba.internals,gmane.linux.kernel,gmane.linux.kernel.perf.user,gmane.linux.kernel.lsm,gmane.linux.file-systems
Message-ID <13960165.uLZWGnKmhe@weasel> 
On Monday, 2 March 2026 21:24:53 CET Jeff Layton wrote:
> Now that i_ino is u64 and the PRIino format macro has been removed,
> replace all uses in 9p with the concrete format strings.
> 
> Signed-off-by: Jeff Layton <[email protected]>
> ---
>  fs/9p/vfs_addr.c       | 4 ++--
>  fs/9p/vfs_inode.c      | 6 +++---
>  fs/9p/vfs_inode_dotl.c | 6 +++---
>  3 files changed, 8 insertions(+), 8 deletions(-)

9p uses the following macro to convert the 9p network protocol's QID path from
u64 (all platforms) to ino_t. The 32-bit path of this macro should be dropped
after this change, as it would unnecessarily truncate the value to 32-bit now
[fs/9p/v9fs_vfs.h]:

#if (BITS_PER_LONG == 32)
#define QID2INO(q) ((ino_t) (((q)->path+2) ^ (((q)->path) >> 32)))
#else
#define QID2INO(q) ((ino_t) ((q)->path+2))
#endif

You are not breaking anything, if you happen to send a v3, that would be nice
to be dropped, otherwise we'll handle that on our end later on:

Reviewed-by: Christian Schoenebeck <[email protected]>

I wonder whether that exceeded Claude's context size, or if that's in line
with the prompt specified by you.

/Christian