Re: [PATCH v2 001/110] vfs: introduce kino_t typedef and PRIino format macro
Christoph Hellwig <[email protected]> Tue, 3 Mar 2026 05:36:38 -0800
| Newsgroups | gmane.linux.file-systems.f2fs,gmane.comp.video.dri.devel,gmane.linux.hams,gmane.comp.file-systems.ceph.devel,gmane.linux.kernel,gmane.linux.kernel.perf.user,gmane.linux.drivers.video-input-infrastructure,gmane.network.samba.internals,gmane.linux.kernel.cifs,gmane.comp.file-systems.nilfs.user,gmane.linux.can,gmane.linux.drivers.mtd,gmane.comp.freedesktop.amd-gfx,gmane.linux.kernel.autofs,gmane.linux.nfs,gmane.comp.file-systems.ext4,gmane.linux.kernel.mm,gmane.linux.network,gmane.linux.file-systems,gmane.linux.kernel.bpf,gmane.comp.file-systems.ecryptfs.general,gmane.linux.file-systems.union,gmane.linux.x25,gmane.linux.bluez.kernel,gmane.comp.file-systems.coda.general,gmane.comp.security.apparmor,gmane.linux.kernel.lsm |
|---|---|
| Message-ID | <[email protected]> |
On Mon, Mar 02, 2026 at 08:25:46PM -0800, Darrick J. Wong wrote: > > That being said, the userspace PRIu64, et. al macros are complete > > format specifiers, not just a length modifier. And I think this > > results in less ugly format specifiers in our kernel code. > > Yeah, I don't like "ino=%" PRIino "u, lolz\n" either. I'd rather have > the whole format in the PRIino definition -- it /is/ unsigned long > after all. Just drop the bloody macro and the pointless micro-splitting of the change. After this the inode is always 64-bit and we can just use normal ll specifiers without messing things up.