Re: [PATCH v3 06/12] ext2: widen trace event i_ino fields to u64
Jan Kara <[email protected]> Thu, 5 Mar 2026 10:44:35 +0100
| Newsgroups | gmane.linux.file-systems.f2fs,gmane.comp.video.dri.devel,gmane.linux.hams,gmane.comp.file-systems.ceph.devel,gmane.linux.kernel,gmane.linux.kernel.perf.user,gmane.linux.drivers.video-input-infrastructure,gmane.linux.kernel.cifs,gmane.comp.file-systems.nilfs.user,gmane.comp.file-systems.coda.general,gmane.linux.can,gmane.linux.drivers.mtd,gmane.comp.freedesktop.amd-gfx,gmane.linux.kernel.autofs,gmane.linux.nfs,gmane.comp.file-systems.ext4,gmane.linux.kernel.mm,gmane.network.samba.internals,gmane.linux.network,gmane.linux.file-systems,gmane.linux.kernel.bpf,gmane.comp.file-systems.ecryptfs.general,gmane.linux.file-systems.union,gmane.linux.x25,gmane.linux.bluez.kernel,gmane.comp.security.apparmor,gmane.linux.kernel.lsm |
|---|---|
| Message-ID | <bfltjtuvcxljfok7wqk4jgefhk6zeix6hbdwzaj3fel3j6z6l2@stzidu4vmlhu> |
On Wed 04-03-26 10:32:36, Jeff Layton wrote: > Update ext2 trace event definitions to use u64 instead of > ino_t/unsigned long for inode number fields. > > Signed-off-by: Jeff Layton <[email protected]> Looks good. Feel free to add: Reviewed-by: Jan Kara <[email protected]> Honza > --- > fs/ext2/trace.h | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/fs/ext2/trace.h b/fs/ext2/trace.h > index 7d230e13576e78713846248eeb21fa0770130540..0922c0e6aab8531c9f5646d86758e6e3595754db 100644 > --- a/fs/ext2/trace.h > +++ b/fs/ext2/trace.h > @@ -13,7 +13,7 @@ DECLARE_EVENT_CLASS(ext2_dio_class, > TP_ARGS(iocb, iter, ret), > TP_STRUCT__entry( > __field(dev_t, dev) > - __field(ino_t, ino) > + __field(u64, ino) > __field(loff_t, isize) > __field(loff_t, pos) > __field(size_t, count) > @@ -31,7 +31,7 @@ DECLARE_EVENT_CLASS(ext2_dio_class, > __entry->aio = !is_sync_kiocb(iocb); > __entry->ret = ret; > ), > - TP_printk("dev %d:%d ino 0x%lx isize 0x%llx pos 0x%llx len %zu flags %s aio %d ret %zd", > + TP_printk("dev %d:%d ino 0x%llx isize 0x%llx pos 0x%llx len %zu flags %s aio %d ret %zd", > MAJOR(__entry->dev), MINOR(__entry->dev), > __entry->ino, > __entry->isize, > @@ -57,7 +57,7 @@ TRACE_EVENT(ext2_dio_write_endio, > TP_ARGS(iocb, size, ret), > TP_STRUCT__entry( > __field(dev_t, dev) > - __field(ino_t, ino) > + __field(u64, ino) > __field(loff_t, isize) > __field(loff_t, pos) > __field(ssize_t, size) > @@ -75,7 +75,7 @@ TRACE_EVENT(ext2_dio_write_endio, > __entry->aio = !is_sync_kiocb(iocb); > __entry->ret = ret; > ), > - TP_printk("dev %d:%d ino 0x%lx isize 0x%llx pos 0x%llx len %zd flags %s aio %d ret %d", > + TP_printk("dev %d:%d ino 0x%llx isize 0x%llx pos 0x%llx len %zd flags %s aio %d ret %d", > MAJOR(__entry->dev), MINOR(__entry->dev), > __entry->ino, > __entry->isize, > > -- > 2.53.0 > -- Jan Kara <[email protected]> SUSE Labs, CR