Re: [PATCH v3 02/12] audit: widen ino fields to u64
Paul Moore <[email protected]> Thu, 5 Mar 2026 22:09:12 -0500
| Newsgroups | gmane.linux.hams,gmane.linux.file-systems,gmane.linux.kernel,gmane.linux.kernel.mm,gmane.comp.file-systems.ext4,gmane.linux.file-systems.f2fs,gmane.linux.nfs,gmane.linux.kernel.cifs,gmane.network.samba.internals,gmane.comp.file-systems.nilfs.user,gmane.linux.kernel.autofs,gmane.comp.file-systems.ceph.devel,gmane.comp.file-systems.coda.general,gmane.comp.file-systems.ecryptfs.general,gmane.linux.drivers.mtd,gmane.linux.file-systems.union,gmane.comp.security.apparmor,gmane.linux.kernel.lsm,gmane.comp.freedesktop.amd-gfx,gmane.comp.video.dri.devel,gmane.linux.drivers.video-input-infrastructure,gmane.linux.network,gmane.linux.kernel.perf.user,gmane.linux.x25,gmane.linux.bluez.kernel,gmane.linux.can,gmane.linux.kernel.bpf |
|---|---|
| Message-ID | <CAHC9VhQix8opxrX--w-pw5vEAiLaYX=kPhnm4x+dEFEwHiVnfQ@mail.gmail.com> |
On Wed, Mar 4, 2026 at 10:33=E2=80=AFAM Jeff Layton <[email protected]> wr= ote: > > inode->i_ino is being widened from unsigned long to u64. The audit > subsystem uses unsigned long ino in struct fields, function parameters, > and local variables that store inode numbers from arbitrary filesystems. > On 32-bit platforms this truncates inode numbers that exceed 32 bits, > which will cause incorrect audit log entries and broken watch/mark > comparisons. > > Widen all audit ino fields, parameters, and locals to u64, and update > the inode format string from %lu to %llu to match. > > Signed-off-by: Jeff Layton <[email protected]> > --- > include/linux/audit.h | 2 +- > kernel/audit.h | 13 ++++++------- > kernel/audit_fsnotify.c | 4 ++-- > kernel/audit_watch.c | 12 ++++++------ > kernel/auditsc.c | 4 ++-- > 5 files changed, 17 insertions(+), 18 deletions(-) Acked-by: Paul Moore <[email protected]> --=20 paul-moore.com