[PATCH] I2C updates: Document that the "id" member of the i2c_client structure was discarded in Linux 2.6.
Linux Kernel Mailing List <[email protected]>
| Newsgroups | gmane.linux.kernel.commits.2-4 |
|---|---|
| Message-ID | <[email protected]> |
ChangeSet 1.1586, 2005/01/29 14:23:05-02:00, [email protected] [PATCH] I2C updates: Document that the "id" member of the i2c_client structure was discarded in Linux 2.6. Original discussion: http://archives.andrew.net.au/lm-sensors/msg29038.html http://archives.andrew.net.au/lm-sensors/msg29041.html Bottom line: The "id" member of the i2c_client structure was discarded in Linux 2.6 due to a lack of consistent use and overall need. While we of course won't backport this to Linux 2.4 so as to not break compatibility with existing 2.4 drivers, it still seems wise to update the documentation so that new drivers written for Linux 2.4 today (*sigh*) do not rely on it. writing-clients | 4 ---- 1 files changed, 4 deletions(-) diff -Nru a/Documentation/i2c/writing-clients b/Documentation/i2c/writing-clients --- a/Documentation/i2c/writing-clients 2005-01-30 15:37:17 -08:00 +++ b/Documentation/i2c/writing-clients 2005-01-30 15:37:17 -08:00 @@ -380,9 +380,6 @@ For now, you can ignore the `flags' parameter. It is there for future use. - /* Unique ID allocation */ - static int foo_id = 0; - int foo_detect_client(struct i2c_adapter *adapter, int address, unsigned short flags, int kind) { @@ -518,7 +515,6 @@ data->type = kind; /* SENSORS ONLY END */ - new_client->id = foo_id++; /* Automatically unique */ data->valid = 0; /* Only if you use this field */ init_MUTEX(&data->update_lock); /* Only if you use this field */