[PATCH] off-by-one in mtrr.c found by Brad Spengler and reported by Julien Tinnes

Linux Kernel Mailing List <[email protected]> Mon, 30 May 2005 15:48:28 +0000

Newsgroups	gmane.linux.kernel.commits.2-4
Message-ID	<[email protected]>

ChangeSet 1.1563, 2005/05/30 12:48:28-03:00, [email protected]

	[PATCH] off-by-one in mtrr.c found by Brad Spengler and reported by Julien Tinnes
	
	off-by-one found by Brad Spengler, reported by Julien Tinnes
	which could lead to a panic.



 mtrr.c |    1 +
 1 files changed, 1 insertion(+)


diff -Nru a/arch/i386/kernel/mtrr.c b/arch/i386/kernel/mtrr.c
--- a/arch/i386/kernel/mtrr.c	2005-05-30 14:03:28 -07:00
+++ b/arch/i386/kernel/mtrr.c	2005-05-30 14:03:28 -07:00
@@ -1674,6 +1674,7 @@
     char *ptr;
     char line[LINE_SIZE];
 
+    if (!len) return -EINVAL;
     if ( !suser () ) return -EPERM;
     /*  Can't seek (pwrite) on this device  */
     if (ppos != &file->f_pos) return -ESPIPE;