[PATCH] netdrv: b44 driver must ignore carrier lost errors
Linux Kernel Mailing List <[email protected]> Fri, 12 May 2006 18:59:48 GMT
| Newsgroups | gmane.linux.kernel.commits.2-4 |
|---|---|
| Message-ID | <[email protected]> |
commit daf87944b986566439dd65393eee561b263aba68 tree 1133c457b46b29c61c47f436653daeb0a45ce1f6 parent 66cd21fae5844a8f575b05e143e5ba77905d9613 author Willy TARREAU <willy@pcw.(none)> Sun, 07 May 2006 23:38:01 +0200 committer Willy TARREAU <willy@pcw.(none)> Sun, 07 May 2006 23:38:01 +0200 [PATCH] netdrv: b44 driver must ignore carrier lost errors some (?) hardware seems to be buggy and is reporting bogus carrier lost values. Both reference implementations from Broadcom indicate that this counter is not reliable and therefore ignore it. We should do the same. "Fixes" the carrier lost problem i've seen. Signed-off-by: Florian Schirmer <[email protected]> Note: This patch was merged in 2.6 in early 2005. Signed-off-by: Willy Tarreau <[email protected]> - Willy drivers/net/b44.c | 3 +++ 1 files changed, 3 insertions(+) diff --git a/drivers/net/b44.c b/drivers/net/b44.c index 0c489a9..081e506 100644 --- a/drivers/net/b44.c +++ b/drivers/net/b44.c @@ -1320,7 +1320,10 @@ static struct net_device_stats *b44_get_ hwstat->rx_symbol_errs); nstat->tx_aborted_errors = hwstat->tx_underruns; +#if 0 + /* Carrier lost counter seems to be broken for some devices */ nstat->tx_carrier_errors = hwstat->tx_carrier_lost; +#endif return nstat; }