MIPS: math-emu: Avoid an assignment within if statement condition

Web:        https://git.kernel.org/torvalds/c/8904d5b1a31febe0ced1f56aa347e761668af571
Commit:     8904d5b1a31febe0ced1f56aa347e761668af571
Parent:     95306f0469580ba94e909d63ee1e2a67c5dc5cba
Refname:    refs/heads/master
Author:     Aleksandar Markovic <[email protected]>
AuthorDate: Thu Nov 2 12:14:03 2017 +0100
Committer:  Ralf Baechle <[email protected]>
CommitDate: Tue Dec 12 17:20:20 2017 +0100

    MIPS: math-emu: Avoid an assignment within if statement condition
    
    Move invocation of fpu_emu() to be out of if statement condition.
    
    This makes code easier to follow and debug, and fixes a checkpatch
    warning.
    
    Signed-off-by: Aleksandar Markovic <[email protected]>
    Cc: Douglas Leung <[email protected]>
    Cc: Goran Ferenc <[email protected]>
    Cc: James Hogan <[email protected]>
    Cc: Maciej W. Rozycki <[email protected]>
    Cc: Miodrag Dinic <[email protected]>
    Cc: Paul Burton <[email protected]>
    Cc: Petar Jovanovic <[email protected]>
    Cc: Raghu Gandham <[email protected]>
    Cc: [email protected]
    Cc: [email protected]
    Patchwork: https://patchwork.linux-mips.org/patch/17586/
    Signed-off-by: Ralf Baechle <[email protected]>
---
 arch/mips/math-emu/cp1emu.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/arch/mips/math-emu/cp1emu.c b/arch/mips/math-emu/cp1emu.c
index da6c1c0c30c1..9e5c8806e43a 100644
--- a/arch/mips/math-emu/cp1emu.c
+++ b/arch/mips/math-emu/cp1emu.c
@@ -1353,7 +1353,8 @@ branch_common:
 				return SIGILL;
 
 			/* a real fpu computation instruction */
-			if ((sig = fpu_emu(xcp, ctx, ir)))
+			sig = fpu_emu(xcp, ctx, ir);
+			if (sig)
 				return sig;
 		}
 		break;
--
To unsubscribe from this list: send the line "unsubscribe git-commits-head" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html