ASoC: soc-pcm: don't call flush_delayed_work() many times in soc_pcm_private_free()
"Linux Kernel Mailing List" <[email protected]>
| Newsgroups | gmane.linux.kernel.commits.head |
|---|---|
| Message-ID | <[email protected]> |
Web: https://git.kernel.org/torvalds/c/f30a4c313eb6d5027a85869d1ccf626208218ed0 Commit: f30a4c313eb6d5027a85869d1ccf626208218ed0 Parent: 4fbd8d194f06c8a3fd2af1ce560ddb31f7ec8323 Refname: refs/heads/master Author: Kuninori Morimoto <[email protected]> AuthorDate: Wed Jan 24 05:18:46 2018 +0000 Committer: Mark Brown <[email protected]> CommitDate: Wed Jan 24 10:30:20 2018 +0000 ASoC: soc-pcm: don't call flush_delayed_work() many times in soc_pcm_private_free() commit f523acebbb74 ("ASoC: add Component level pcm_new/pcm_free v2") added component level pcm_new/pcm_free, but flush_delayed_work() on soc_pcm_private_free() is called in for_each_rtdcom() loop. It doesn't need to be called many times. This patch moves it out of loop. Signed-off-by: Kuninori Morimoto <[email protected]> Signed-off-by: Mark Brown <[email protected]> --- sound/soc/soc-pcm.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/sound/soc/soc-pcm.c b/sound/soc/soc-pcm.c index 8075856668c2..998800cc44ef 100644 --- a/sound/soc/soc-pcm.c +++ b/sound/soc/soc-pcm.c @@ -2831,10 +2831,9 @@ static void soc_pcm_private_free(struct snd_pcm *pcm) struct snd_soc_rtdcom_list *rtdcom; struct snd_soc_component *component; + /* need to sync the delayed work before releasing resources */ + flush_delayed_work(&rtd->delayed_work); for_each_rtdcom(rtd, rtdcom) { - /* need to sync the delayed work before releasing resources */