watchdog: i6300esb: remove info message and version number
"Linux Kernel Mailing List" <[email protected]>
| Newsgroups | gmane.linux.kernel.commits.head |
|---|---|
| Message-ID | <[email protected]> |
Web: https://git.kernel.org/torvalds/c/788c2fdb4f6f1d781d9db584f0c9bca54043dc84 Commit: 788c2fdb4f6f1d781d9db584f0c9bca54043dc84 Parent: 568d6015dbdef2c437da2fb6e697c43df6a52fea Refname: refs/heads/master Author: Radu Rendec <[email protected]> AuthorDate: Thu Oct 26 17:10:16 2017 +0100 Committer: Wim Van Sebroeck <[email protected]> CommitDate: Thu Dec 28 20:45:18 2017 +0100 watchdog: i6300esb: remove info message and version number The initial info message (early in the esb_probe() function) is not very useful and we already have a message on successful probe, which includes device identification. If the probe fails (e.g. PCI related errors), additional messages are printed anyway. The version number was only used in the initial info message. Other than that, it serves no useful purpose and it ran out of favor upstream anyway. Signed-off-by: Radu Rendec <[email protected]> Reviewed-by: Guenter Roeck <[email protected]> Signed-off-by: Guenter Roeck <[email protected]> Signed-off-by: Wim Van Sebroeck <[email protected]> --- drivers/watchdog/i6300esb.c | 11 ----------- 1 file changed, 11 deletions(-) diff --git a/drivers/watchdog/i6300esb.c b/drivers/watchdog/i6300esb.c index 4d92925cdc1e..950c71a8bb22 100644 --- a/drivers/watchdog/i6300esb.c +++ b/drivers/watchdog/i6300esb.c @@ -30,8 +30,6 @@ * Includes, defines, variables, module parameters, ... */ -#define pr_fmt(fmt) KBUILD_MODNAME ": " fmt - #include <linux/module.h> #include <linux/types.h> #include <linux/kernel.h> @@ -45,7 +43,6 @@ #include <linux/io.h> /* Module and version information */ -#define ESB_VERSION "0.05" #define ESB_MODULE_NAME "i6300ESB timer" /* PCI configuration registers */ @@ -76,9 +73,6 @@ #define ESB_UNLOCK1 0x80 /* Step 1 to unlock reset registers */ #define ESB_UNLOCK2 0x86 /* Step 2 to unlock reset registers */ -/* Probed devices counter; used only for printing the initial info message */ -static int cards_found; - /* module parameters */ /* 30 sec default heartbeat (1 < heartbeat < 2*1023) */ #define ESB_HEARTBEAT_MIN 1 @@ -302,11 +296,6 @@ static int esb_probe(struct pci_dev *pdev, struct esb_dev *edev; int ret; - cards_found++; - if (cards_found == 1) - pr_info("Intel 6300ESB WatchDog Timer Driver v%s\n", - ESB_VERSION);