ocxl: fix signed comparison with less than zero

"Linux Kernel Mailing List" <[email protected]> Wed, 14 Feb 2018 18:19:52 +0000 (UTC)
Newsgroups gmane.linux.kernel.commits.head
Message-ID <[email protected]>
Web:        https://git.kernel.org/torvalds/c/dedab7f0d3137441a97fe7cf9b9ca5dbd20ca9a5
Commit:     dedab7f0d3137441a97fe7cf9b9ca5dbd20ca9a5
Parent:     6cc3f91bf69fc8c1719704607474f9b9df56f348
Refname:    refs/heads/master
Author:     Colin Ian King <[email protected]>
AuthorDate: Tue Jan 30 15:11:44 2018 +0000
Committer:  Michael Ellerman <[email protected]>
CommitDate: Thu Feb 8 23:56:11 2018 +1100

    ocxl: fix signed comparison with less than zero
    
    Currently the comparison of used < 0 is always false because
    uses is a size_t. Fix this by making used a ssize_t type.
    
    Detected by Coccinelle:
    drivers/misc/ocxl/file.c:320:6-10: WARNING: Unsigned expression
    compared with zero: used < 0
    
    Fixes: 5ef3166e8a32 ("ocxl: Driver code for 'generic' opencapi devices")
    Signed-off-by: Colin Ian King <[email protected]>
    Acked-by: Andrew Donnellan <[email protected]>
    Acked-by: Frederic Barrat <[email protected]>
    Signed-off-by: Michael Ellerman <[email protected]>
---
 drivers/misc/ocxl/file.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/misc/ocxl/file.c b/drivers/misc/ocxl/file.c
index c90c1a578d2f..1287e4430e6b 100644
--- a/drivers/misc/ocxl/file.c
+++ b/drivers/misc/ocxl/file.c
@@ -277,7 +277,7 @@ static ssize_t afu_read(struct file *file, char __user *buf, size_t count,
 	struct ocxl_context *ctx = file->private_data;
 	struct ocxl_kernel_event_header header;
 	ssize_t rc;
-	size_t used = 0;
+	ssize_t used = 0;
 	DEFINE_WAIT(event_wait);
 
 	memset(&header, 0, sizeof(header));
--
To unsubscribe from this list: send the line "unsubscribe git-commits-head" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html