opp: cpu: Replace GFP_ATOMIC with GFP_KERNEL in dev_pm_opp_init_cpufreq_table

Web:        https://git.kernel.org/torvalds/c/4a823c0be80fa996234ebb41c80d40458b1bec1e
Commit:     4a823c0be80fa996234ebb41c80d40458b1bec1e
Parent:     7928b2cbe55b2a410a0f5c1f154610059c57b1b2
Refname:    refs/heads/master
Author:     Jia-Ju Bai <[email protected]>
AuthorDate: Fri Jan 26 16:48:49 2018 +0800
Committer:  Viresh Kumar <[email protected]>
CommitDate: Mon Feb 12 15:07:46 2018 +0530

    opp: cpu: Replace GFP_ATOMIC with GFP_KERNEL in dev_pm_opp_init_cpufreq_table
    
    After checking all possible call chains to
    dev_pm_opp_init_cpufreq_table() here,
    my tool finds that this function is never called in atomic context,
    namely never in an interrupt handler or holding a spinlock.
    And dev_pm_opp_init_cpufreq_table() calls dev_pm_opp_get_opp_count(),
    which calls mutex_lock that can sleep.
    It indicates that atmtcp_v_send() can call functions which may sleep.
    Thus GFP_ATOMIC is not necessary, and it can be replaced with GFP_KERNEL.
    
    This is found by a static analysis tool named DCNS written by myself.
    
    Signed-off-by: Jia-Ju Bai <[email protected]>
    Signed-off-by: Viresh Kumar <[email protected]>
---
 drivers/opp/cpu.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/opp/cpu.c b/drivers/opp/cpu.c
index 2d87bc1adf38..0c0910709435 100644
--- a/drivers/opp/cpu.c
+++ b/drivers/opp/cpu.c
@@ -55,7 +55,7 @@ int dev_pm_opp_init_cpufreq_table(struct device *dev,
 	if (max_opps <= 0)
 		return max_opps ? max_opps : -ENODATA;
 
-	freq_table = kcalloc((max_opps + 1), sizeof(*freq_table), GFP_ATOMIC);
+	freq_table = kcalloc((max_opps + 1), sizeof(*freq_table), GFP_KERNEL);
 	if (!freq_table)
 		return -ENOMEM;
 
--
To unsubscribe from this list: send the line "unsubscribe git-commits-head" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html