Re: [PATCH] fix of unnecessary clocksource change after exiting from KDB console

On Fri, 3 Aug 2007 21:25:14 +0400
Konstantin Baydarov <[email protected]> wrote:

> I'm afraid that previous patch won't work with SMP kernel with high
> resolution timer enabled, because of hres_timers_resume(): /*
>  * During resume we might have to reprogram the high resolution timer
>  * interrupt (on the local CPU):
>  */
> void hres_timers_resume(void)
> {
> 	WARN_ON_ONCE(num_online_cpus() > 1);
> 
> 	/* Retrigger the CPU local events: */
> 	retrigger_next_event(NULL);
> }
> When we call hres_timers_resume() from timekeeping_resume() other
> CPUs should be in offline. AFAIK, KDB doesn't put CPUs to offline.
> 
> Here Is new version on fix. Patch against 2.6.23-rc1. I've tested it
> on UP pentium4.
> Soft Lockup fix was taken from KGDB mailing list.
> To prevent unnecessary clocksource change I call
> clocksource_resume_watchdog() instead of suspending whole timekeeping 
> system.

KGDB has the same problem with unnecessary clocksource change. I've suggest patch that fixes the problem the same way.
Patch was accepted with small changes:
http://kgdb.cvs.sourceforge.net/kgdb/kgdb-2/clocksource_watchdog.patch?view=log&pathrev=linux2_6_23_uprev

---------------------------
Use http://oss.sgi.com/ecartis to modify your settings or to unsubscribe.