Re: [PATCH] Add support for USB Keyboard attached to UHCI

jidong xiao wrote:
> 
> Has anyone else applied this patch?I am facing errors while compiling
> kernel with this patch.
> 
> localhost:/usr/src/linux-2.6.24-rc2 # make
> ...
> ...
> ...
>   CC      arch/x86/lib/msr-on-cpu.o
>   LD      arch/x86/lib/built-in.o
>   CC      arch/x86/lib/bitops_32.o
>   CC      arch/x86/lib/delay_32.o
>   AS      arch/x86/lib/getuser_32.o
>   CC      arch/x86/lib/memcpy_32.o
>   AS      arch/x86/lib/putuser_32.o
>   AS      arch/x86/lib/semaphore_32.o
>   CC      arch/x86/lib/string_32.o
>   CC      arch/x86/lib/usercopy_32.o
>   AR      arch/x86/lib/lib.a
>   GEN     .version
>   CHK     include/linux/compile.h
>   UPD     include/linux/compile.h
>   CC      init/version.o
>   LD      init/built-in.o
>   LD      .tmp_vmlinux1
> arch/x86/kdb/built-in.o: In function `kdb_usb_uhci_keyboard_attach':
> (.text+0xee4): undefined reference to `usb_buffer_alloc'
> arch/x86/kdb/built-in.o: In function `kdb_usb_uhci_keyboard_attach':
> (.text+0xf01): undefined reference to `usb_alloc_urb'
> arch/x86/kdb/built-in.o: In function `kdb_usb_uhci_keyboard_attach':
> (.text+0xf70): undefined reference to `usb_submit_urb'
> arch/x86/kdb/built-in.o: In function `kdb_usb_uhci_keyboard_attach':
> (.text+0xfb3): undefined reference to `usb_buffer_free'
> arch/x86/kdb/built-in.o: In function `kdb_usb_uhci_keyboard_attach':
> (.text+0xfc5): undefined reference to `usb_free_urb'
> make: *** [.tmp_vmlinux1] Error 1
> localhost:/usr/src/linux-2.6.24-rc2 # make
>   CHK     include/linux/version.h
>   CHK     include/linux/utsrelease.h
>   CALL    scripts/checksyscalls.sh
>   CHK     include/linux/compile.h
>   GEN     .version
>   CHK     include/linux/compile.h
>   UPD     include/linux/compile.h
>   CC      init/version.o
>   LD      init/built-in.o
>   LD      .tmp_vmlinux1
> arch/x86/kdb/built-in.o: In function `kdb_usb_uhci_keyboard_attach':
> (.text+0xee4): undefined reference to `usb_buffer_alloc'
> arch/x86/kdb/built-in.o: In function `kdb_usb_uhci_keyboard_attach':
> (.text+0xf01): undefined reference to `usb_alloc_urb'
> arch/x86/kdb/built-in.o: In function `kdb_usb_uhci_keyboard_attach':
> (.text+0xf70): undefined reference to `usb_submit_urb'
> arch/x86/kdb/built-in.o: In function `kdb_usb_uhci_keyboard_attach':
> (.text+0xfb3): undefined reference to `usb_buffer_free'
> arch/x86/kdb/built-in.o: In function `kdb_usb_uhci_keyboard_attach':
> (.text+0xfc5): undefined reference to `usb_free_urb'
> make: *** [.tmp_vmlinux1] Error 1
> 
> This is quite strange, as I see usb_buffer_alloc is declared in
> <linux/usb.h>,and kdba_io_32.c includes <linux/kdb.h> which then
> includes <linux/usb.h>. I am sure CONFIG_KDB_USB is enabled. So I am
> now frustrated with this issue.

I have not merged this patch yet, but those missing routines are defined
in drivers/usb/core/{usb,urb}.c, and these routines will get compiled
if CONFIG_USB is set.

Is it possible that you used editor to enable CONFIG_KDB_USB? If you
enable the config flag through 'make oldconfig', you need to have
CONFIG_OHCI_HCD to enable CONFIG_KDB_USB. I think it then requires
CONFIG_USB and then you should have had the missing routines.

Thanks,
 - jay

> 
> Regards
> Jason
> ---------------------------
> Use http://oss.sgi.com/ecartis to modify your settings or to unsubscribe.

---------------------------
Use http://oss.sgi.com/ecartis to modify your settings or to unsubscribe.