Re: [PATCH 20/20] kdb-clocksource-resync

[email protected] wrote:
> Fix up the clocksource watchdog whenever we leave KDB.

Thanks. This one did not make it to kdb-2.6.26-rc9-*. Queued
up for next update.

Regards,
 - jay

> 
> Without this fixup, the TSC will be marked unstable
> whenever we leave KDB after being in KDB for 'too long'
> (tens of seconds).  This is an undesireable system
> interaction with a measurement tool, as being marked
> unstable means the system has removed the TSC as a source
> of system time.
> 
> Typical message:
> 
>     [3]kdb> g
>     Clocksource tsc unstable (delta = 4687003347 ns)
> 
> Signed-off-by: Joe Korty <[email protected]>
> 
> Index: 2.6.26-rc9/kdb/kdbmain.c
> ===================================================================
> --- 2.6.26-rc9.orig/kdb/kdbmain.c	2008-07-10 18:31:11.000000000 -0400
> +++ 2.6.26-rc9/kdb/kdbmain.c	2008-07-11 11:46:18.000000000 -0400
> @@ -40,6 +40,7 @@
>  #include <linux/dump.h>
>  #endif
>  #include <linux/cpu.h>
> +#include <linux/clocksource.h>
>  #include <linux/kdebug.h>
>  
>  #include <acpi/acpi_bus.h>
> @@ -2122,6 +2123,7 @@
>  			kdbnearsym_cleanup();
>  			debug_kusage();
>  		}
> +		clocksource_touch_watchdog();
>  		if (!KDB_STATE(GO1)) {
>  			/*
>  			 * Release all other cpus which will see KDB_STATE(LEAVING) is set.
> ---------------------------
> Use http://oss.sgi.com/ecartis to modify your settings or to unsubscribe.

---------------------------
Use http://oss.sgi.com/ecartis to modify your settings or to unsubscribe.