Re: [PATCH 07/37] kgdb,sparc: Add in kgdb_arch_set_pc for sparc

David Miller <[email protected]> Wed, 23 Dec 2009 13:48:37 -0800 (PST)
Newsgroups gmane.linux.kernel,gmane.linux.kernel.debugging.kgdb.bugs,gmane.linux.kernel.debugging
Message-ID <[email protected]>
From: Jason Wessel <[email protected]>
Date: Wed, 23 Dec 2009 15:19:20 -0600

> +void kgdb_arch_set_pc(struct pt_regs *regs, unsigned long ip)
> +{
> +       regs->pc = regs->npc;
> +       regs->npc = ip;
> +}
> +

Is this right?

It should probably be something like:

> +       regs->pc = ip;
> +       regs->npc = regs->pc + 4;

and similary for sparc64.