Re: Bug in cryptsetup 2.3.0 (BitLocker key-file support)

Arno Wagner <[email protected]>
Newsgroups gmane.linux.kernel.device-mapper.dm-crypt
Message-ID <[email protected]>
On Wed, Feb 19, 2020 at 21:57:23 CET, Milan Broz wrote:
> On 19/02/2020 21:13, Quentin Lefebvre wrote:
> > The on-disk keyfile was the printed recovery passphrase provided by 
> > Windows...
> > 
> >  > So what is the exact content of your keyfile? Is there additional EOL,
> >  > or it had some more characters there?
> > 
> > ls -l <my_recovery_password_file>
> > showed a 56 bytes file and
> > 
> > hexdump -C <my_recovery_password_file>
> > showed a trailing '\x0a' character added by my favorite editor.
> > 
> > Removing it with dd(!) solved my problem...
> 
> ok, thanks for the info.
> 
> But I think we should perhaps process even this file (recovery
> passphrase has a special format - if it is detected, we try to use it,
> otherwise we parse it as a normal passphrase).
> I think we can do this even if it is has an additional EOL there.

I would suggest giving a verbose warning in this case.
Something like, "recovery passphrase detected, extra EOL chars stripped."

Regards,
Arno

-- 
Arno Wagner,     Dr. sc. techn., Dipl. Inform.,    Email: [email protected]
GnuPG: ID: CB5D9718  FP: 12D6 C03B 1B30 33BB 13CF  B774 E35C 5FA1 CB5D 9718
----
A good decision is based on knowledge and not on numbers. -- Plato

If it's in the news, don't worry about it.  The very definition of 
"news" is "something that hardly ever happens." -- Bruce Schneier
_______________________________________________
dm-crypt mailing list
[email protected]
https://www.saout.de/mailman/listinfo/dm-crypt
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.