[evlog-dev] Questions about evlog
Benoit Guillon <[email protected]> Wed, 14 Apr 2004 10:33:50 +0200
| Newsgroups | gmane.linux.kernel.event-logging |
|---|---|
| Message-ID | <[email protected]> |
--------------C33433299642E8334B70C4C2
Content-Type: text/plain; charset=iso-8859-1
Content-Transfer-Encoding: Quoted-Printable
Hello all,
I'm new to the list, and I've subscribed because I'm interested in the
subject. I've downloaded release evlog-1.6.0-b2, and I've few remarks:
* Why so recent configure, automake, autoconf, etc. are needed? I don't
know if this is the reason why, but with oldest version of these tools
the macro EVLOG_STATE_DIR is not defined in any header file. I've
temporary added it in config.h.
* There's a little bug in _evlWriteEx(): when (sd < 0) the function
returns and the mutex is still locked (and the signals masked!). I
suggest the following changes:
--- ../posix2.c Wed Mar 31 02:36:09 2004
+++ ../posix2.c.new Wed Apr 14 10:21:27 2004
@@ -709,7 +709,8 @@
sd =3D getSdByPid(entry->log_pid);
if (sd < 0) {
- return ECONNREFUSED;
+ ret =3D ECONNREFUSED;
+ goto unlock_and_exit;
}
ret =3D _evlWriteEx2(sd, entry, buf);
@@ -728,6 +729,7 @@
close(sd);
zapSd(sd);
}
+unlock_and_exit:
if (sigsBlocked) {
_evlRestoreSignals(&oldset);
}
Besides, I've little questions:
* Do you know where I can have a free copy of the P1003.25 standard (no
more available on the sourceforge site)?
* Is this standard mature (when did it start)? Was it previously
referenced as 1003.1h?
* Can we see some relationship (if any) with the POSIX trace API defined
in P1003.1 or is the scope completely different?
Thanks for your responses,
Bye,
--
Beno=EEt Guillon [email protected]
--------------C33433299642E8334B70C4C2
Content-Type: text/html; charset=us-ascii
Content-Transfer-Encoding: 7Bit
<!doctype html public "-//w3c//dtd html 4.0 transitional//en">
<html>
Hello all,
<p>I'm new to the list, and I've subscribed because I'm interested in the
subject. I've downloaded release evlog-1.6.0-b2, and I've few remarks:
<p>* Why so recent configure, automake, autoconf, etc. are needed? I don't
know if this is the reason why, but with oldest version of these tools
the macro EVLOG_STATE_DIR is not defined in any header file. I've temporary
added it in config.h.
<br>* There's a little bug in _evlWriteEx(): when (sd < 0) the function
returns and the mutex is still locked (and the signals masked!). I suggest
the following changes:
<p><tt>--- ../posix2.c Wed Mar 31 02:36:09 2004</tt>
<br><tt>+++ ../posix2.c.new Wed Apr 14 10:21:27 2004</tt>
<br><tt>@@ -709,7 +709,8 @@</tt>
<br><tt> </tt>
<br><tt> sd = getSdByPid(entry->log_pid);</tt>
<br><tt> if (sd < 0) {</tt>
<br><tt>- return ECONNREFUSED;</tt>
<br><tt>+ ret = ECONNREFUSED;</tt>
<br><tt>+ goto unlock_and_exit;</tt>
<br><tt> }</tt>
<br><tt> </tt>
<br><tt> ret = _evlWriteEx2(sd, entry, buf);</tt>
<br><tt>@@ -728,6 +729,7 @@</tt>
<br><tt> close(sd);</tt>
<br><tt> zapSd(sd);</tt>
<br><tt> }</tt>
<br><tt>+unlock_and_exit:</tt>
<br><tt> if (sigsBlocked) {</tt>
<br><tt> _evlRestoreSignals(&oldset);</tt>
<br><tt> }</tt><tt></tt>
<p>Besides, I've little questions:
<br>* Do you know where I can have a free copy of the P1003.25 standard
(no more available on the sourceforge site)?
<br>* Is this standard mature (when did it start)? Was it previously referenced
as 1003.1h?
<br>* Can we see some relationship (if any) with the POSIX trace API defined
in P1003.1 or is the scope completely different?
<p>Thanks for your responses,
<p>Bye,
<pre>--
Benoît Guillon [email protected]
</pre>
</html>
--------------C33433299642E8334B70C4C2--
-------------------------------------------------------
This SF.Net email is sponsored by: IBM Linux Tutorials
Free Linux tutorial presented by Daniel Robbins, President and CEO of
GenToo technologies. Learn everything from fundamentals to system
administration.http://ads.osdn.com/?ad_id=1470&alloc_id=3638&op=click