Re: [evlog-dev] Portability results

Hien Nguyen <[email protected]> Tue, 11 May 2004 19:27:27 -0700
Newsgroups gmane.linux.kernel.event-logging
Message-ID <[email protected]>
Hi Benoit,

Thanks again for your contribution. Just to let you know that I do not
ignore your mail, I am so busy with some other stuff right now. I will
check back with you later after I look at your patch.=20
See my replies below..



On Mon, 2004-05-10 at 08:58, Benoit Guillon wrote:
> Hello,=20
>=20
> I can now have evlog running on lynx 4.0 PPC boards! I attach the
> patches I did to make it work.=20
>=20
> Most of them are really specific and shouldn't be taken. However here
> are some points that I suggest to check:=20
>=20
> - listen(sd, 0) is really problematic, since it can make the
> evlnotifyd and evlogd daemons to deadlock=20

You're probably right, what do you suggest for queue =3D 0. If want only
one connection on this socket.

> - credential checks are not supported everywhere. Do you know if there
> is a standard way to proceed with it when it is not available?=20

No, I don't know a standard way, hence I implemented something similar
to cron.allow

> - why not using the POSIX sigqueue() function instead of the
> ugly-specific rt_sigqueueinfo syscall? If it is to be able to pass
> extra information, is this information really necessary?=20

Yes, we would like to pass some extra information, it was a posix
requirement. However, I don't know if it is still true.
> - some services are really specific to a linux system
> (_evlGetProcId(), validateProc()). It could be wise to put them in
> separate .c to show clearly what is system specific and what is not.
> What do you think?=20

Good idea. I will do that in next release.
>=20
> In the attached ball I'm sorry to give the patches like this (actually
> there are not usable) but I've changed the source directories and
> Makefiles (needed for our cross development) so that I couldn't make a
> clean single patch file. But I hope it can still be of some use.=20
>=20
> Bye,=20
> --
> Beno=C3=AEt Guillon                [email protected]=20
> =20



-------------------------------------------------------
This SF.Net email is sponsored by Sleepycat Software
Learn developer strategies Cisco, Motorola, Ericsson & Lucent use to 
deliver higher performing products faster, at low TCO.
http://www.sleepycat.com/telcomwpreg.php?From=osdnemail3