Re: [PATCH v2 00/32] driver core: Constify API device_find_child() and adapt for various existing usages
Zijun Hu <[email protected]>
| Newsgroups | gmane.linux.ports.sparc,gmane.linux.kernel,gmane.comp.video.dri.devel,gmane.linux.ports.arm.mediatek,gmane.linux.ports.arm.kernel,gmane.linux.kernel.hwmon,gmane.linux.drivers.video-input-infrastructure,gmane.linux.usb.general,gmane.linux.kernel.gpio,gmane.linux.network,gmane.linux.pwm,gmane.linux.kernel.firewire.devel,gmane.linux.serial,gmane.linux.sound,gmane.linux.iscsi.open-iscsi,gmane.linux.scsi,gmane.linux.block,gmane.linux.kernel.efi |
|---|---|
| Message-ID | <[email protected]> |
On 2024/12/3 20:41, Greg Kroah-Hartman wrote: > On Tue, Dec 03, 2024 at 08:23:45PM +0800, Zijun Hu wrote: >> On 2024/12/3 20:00, Uwe Kleine-König wrote: >>> Hello, >>> >>> On Tue, Dec 03, 2024 at 08:33:22AM +0800, Zijun Hu wrote: >>>> This patch series is to constify the following API: >>>> struct device *device_find_child(struct device *dev, void *data, >>>> int (*match)(struct device *dev, void *data)); >>>> To : >>>> struct device *device_find_child(struct device *dev, const void *data, >>>> device_match_t match); >>>> typedef int (*device_match_t)(struct device *dev, const void *data); >>> >>> This series isn't bisectible. With only the first two patches applied I >>> hit: >> >> yes. such patch series needs to be merge as atomic way. >> >> Hi Greg, >> >> is it possible to ONLY merge such patch series by atomic way into your >> driver-core tree? > > Nope! > >> or squash such patch series into a single patch ? >> >> various subsystem maintainers may not like squashing way. > > Agreed, so look into either doing it in a bisectable way if at all > possible. As I don't see a full series here, I can't suggest how it > needs to happen :( > let me send you a full series later and discuss how to solve this issue. > thanks, > > greg k-h