Re: [PATCH v3 08/11] gpio: sim: Remove gpio_sim_dev_match_fwnode()
Uwe Kleine-König <[email protected]>
| Newsgroups | gmane.linux.kernel.hwmon,gmane.linux.kernel,gmane.linux.sound,gmane.linux.ports.sparc,gmane.linux.block,gmane.linux.kernel.firewire.devel,gmane.linux.kernel.efi,gmane.linux.kernel.gpio,gmane.comp.video.dri.devel,gmane.linux.ports.arm.mediatek,gmane.linux.drivers.video-input-infrastructure,gmane.linux.pwm,gmane.linux.scsi,gmane.linux.iscsi.open-iscsi,gmane.linux.usb.general,gmane.linux.serial,gmane.linux.network |
|---|---|
| Message-ID | <eyu7nm5hvwfqxgysnrzsvianzf7abvlovpxfo7snsxowmuuhpj@tah3gkqm5ldj> |
On Thu, Dec 05, 2024 at 04:37:08PM +0800, quic_zijuhu wrote: > On 12/5/2024 4:10 PM, Uwe Kleine-König wrote: > > On Thu, Dec 05, 2024 at 08:10:17AM +0800, Zijun Hu wrote: > >> From: Zijun Hu <[email protected]> > >> > >> gpio_sim_dev_match_fwnode() is a simple wrapper of device_match_fwnode() > >> Remvoe the unnecessary wrapper. Just spotted: s/Remvoe/Remove/ > >> Signed-off-by: Zijun Hu <[email protected]> > >> --- > >> drivers/gpio/gpio-sim.c | 7 +------ > > > > I think if you move this patch before patch #4 in your series, you only > > have to touch this file once. > > the precondition of this change is patch #4, it will have building error > if moving it before #4. > > actually, we can only do simplifications with benefits brought by #4. Ah I see. I thought that device_match_fwnode only got the const for the 2nd parameter in patch #4. Best regards Uwe
signature.asc
(application/pgp-signature, 488 B)
-----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEP4GsaTp6HlmJrf7Tj4D7WH0S/k4FAmdRgmcACgkQj4D7WH0S /k6zeggAlBhwMJaGpQIgAi04teyouKX4a/XAJG3tLwpz4YweEcrMm/fv0N42hp/d 7zUKHjQRRcVM6+TSObZ6uKEFMpac+G1YG1Fze2rNPdlf5IUOCrpKqKUaziMyvEc+ hhaccpLCXjp9gi7H7tEBDfmrR6/S3i1nnYOeDn6tYmhKVx14uA57l4Isj2h+CIax P5d+Gq9NQl5IXDnqiEez80oo8LFhLQQIjIeO1YQM7GrbXaqoD+CfZTGXe4/woRc5 JjzksiJqSccUbPlwM+90bh5Oj0H2VARUaJTRcHTRANM4ZFTSfWCep0Wkg8DSw343 fYW4rY4vIXpWKVG9LM4j7NAoluIWvQ== =myq/ -----END PGP SIGNATURE-----