Re: [PATCH v3 08/11] gpio: sim: Remove gpio_sim_dev_match_fwnode()
Zijun Hu <[email protected]>
| Newsgroups | gmane.linux.block,gmane.linux.kernel,gmane.linux.sound,gmane.linux.ports.sparc,gmane.linux.kernel.firewire.devel,gmane.linux.kernel.efi,gmane.linux.kernel.gpio,gmane.comp.video.dri.devel,gmane.linux.ports.arm.mediatek,gmane.linux.kernel.hwmon,gmane.linux.drivers.video-input-infrastructure,gmane.linux.pwm,gmane.linux.scsi,gmane.linux.usb.general,gmane.linux.serial,gmane.linux.network |
|---|---|
| Message-ID | <[email protected]> |
On 2024/12/5 18:37, Uwe Kleine-König wrote: > On Thu, Dec 05, 2024 at 04:37:08PM +0800, quic_zijuhu wrote: >> On 12/5/2024 4:10 PM, Uwe Kleine-König wrote: >>> On Thu, Dec 05, 2024 at 08:10:17AM +0800, Zijun Hu wrote: >>>> From: Zijun Hu <[email protected]> >>>> >>>> gpio_sim_dev_match_fwnode() is a simple wrapper of device_match_fwnode() >>>> Remvoe the unnecessary wrapper. > > Just spotted: s/Remvoe/Remove/ > this typo error is my mistake, will correct it. >>>> Signed-off-by: Zijun Hu <[email protected]> >>>> --- >>>> drivers/gpio/gpio-sim.c | 7 +------ >>> >>> I think if you move this patch before patch #4 in your series, you only >>> have to touch this file once. >> >> the precondition of this change is patch #4, it will have building error >> if moving it before #4. >> >> actually, we can only do simplifications with benefits brought by #4. > > Ah I see. I thought that device_match_fwnode only got the const for the > 2nd parameter in patch #4. > > Best regards > Uwe