Re: [PATCH v4 03/11] bus: fsl-mc: Constify fsl_mc_device_match()
Zijun Hu <[email protected]>
| Newsgroups | gmane.linux.ports.sparc,gmane.linux.kernel,gmane.linux.sound,gmane.linux.block,gmane.linux.kernel.firewire.devel,gmane.linux.kernel.efi,gmane.linux.kernel.gpio,gmane.comp.video.dri.devel,gmane.linux.ports.arm.mediatek,gmane.linux.kernel.hwmon,gmane.linux.drivers.video-input-infrastructure,gmane.linux.pwm,gmane.linux.scsi,gmane.linux.usb.general,gmane.linux.serial,gmane.linux.network |
|---|---|
| Message-ID | <[email protected]> |
On 2024/12/24 04:26, Jonathan Cameron wrote: > On Wed, 11 Dec 2024 08:08:05 +0800 > Zijun Hu <[email protected]> wrote: > >> From: Zijun Hu <[email protected]> >> >> fsl_mc_device_match() does not modify caller's inputs. >> >> Constify it by simply changing its parameter types to const pointer. >> >> Signed-off-by: Zijun Hu <[email protected]> > Similar to previous patch, I'd say why you are making this change. > There are may places in the kernel where pointers are constant but > not marked so. Why does this one matter? > thank you for code review. make sense. will correct comment message for this and previous patch in v5. > With that info added > Reviewed-by: Jonathan Cameron <[email protected]>