Re: [PATCH v4 01/11] libnvdimm: Replace namespace_match() with device_find_child_by_name()
Fan Ni <[email protected]>
| Newsgroups | gmane.linux.kernel.gpio,gmane.linux.kernel,gmane.linux.sound,gmane.linux.ports.sparc,gmane.linux.block,gmane.linux.kernel.firewire.devel,gmane.linux.kernel.efi,gmane.comp.video.dri.devel,gmane.linux.ports.arm.mediatek,gmane.linux.kernel.hwmon,gmane.linux.drivers.video-input-infrastructure,gmane.linux.pwm,gmane.linux.scsi,gmane.linux.usb.general,gmane.linux.serial,gmane.linux.network |
|---|---|
| Message-ID | <Z3bYMiOG0u3Jtv3h@smc-140338-bm01> |
On Wed, Dec 11, 2024 at 08:08:03AM +0800, Zijun Hu wrote: > From: Zijun Hu <[email protected]> > > Simplify nd_namespace_store() implementation by > using device_find_child_by_name(). > > Reviewed-by: Alison Schofield <[email protected]> > Signed-off-by: Zijun Hu <[email protected]> > --- > drivers/nvdimm/claim.c | 9 +-------- > 1 file changed, 1 insertion(+), 8 deletions(-) > > diff --git a/drivers/nvdimm/claim.c b/drivers/nvdimm/claim.c > index 030dbde6b0882050c90fb8db106ec15b1baef7ca..9e84ab411564f9d5e7ceb687c6491562564552e3 100644 > --- a/drivers/nvdimm/claim.c > +++ b/drivers/nvdimm/claim.c > @@ -67,13 +67,6 @@ bool nd_attach_ndns(struct device *dev, struct nd_namespace_common *attach, > return claimed; > } > > -static int namespace_match(struct device *dev, void *data) > -{ > - char *name = data; > - > - return strcmp(name, dev_name(dev)) == 0; > -} > - > static bool is_idle(struct device *dev, struct nd_namespace_common *ndns) > { > struct nd_region *nd_region = to_nd_region(dev->parent); > @@ -168,7 +161,7 @@ ssize_t nd_namespace_store(struct device *dev, > goto out; > } > > - found = device_find_child(dev->parent, name, namespace_match); > + found = device_find_child_by_name(dev->parent, name); Looks good to me. Just one general question. The function device_find_child checks parent and parent->p, but device_find_child_by_name only checks parent although they share the code except the match function. Why that? Fan > if (!found) { > dev_dbg(dev, "'%s' not found under %s\n", name, > dev_name(dev->parent)); > > -- > 2.34.1 > -- Fan Ni (From gmail)