Re: [PATCH v2][next] firewire: core: avoid -Wflex-array-member-not-at-end warning
Takashi Sakamoto <[email protected]>
| Newsgroups | gmane.linux.kernel,gmane.linux.kernel.firewire.devel |
|---|---|
| Message-ID | <[email protected]> |
Hi, On Fri, Mar 14, 2025 at 08:58:23AM +1030, Gustavo A. R. Silva wrote: > Use the `DEFINE_RAW_FLEX()` helper for an on-stack definition of > a flexible structure where the size of the flexible-array member > is known at compile-time, and refactor the rest of the code, > accordingly. > > So, with these changes, fix the following warning: > > drivers/firewire/core-cdev.c:1141:38: warning: structure containing a flexible array member is not at the end of another structure [-Wflex-array-member-not-at-end] > > Signed-off-by: Gustavo A. R. Silva <[email protected]> > --- > Changes in v2: > - Adjust COUNT argument for DEFINE_RAW_FLEX() to 64. (Takashi) > > v1: > - Link: https://lore.kernel.org/linux-hardening/Z9AA9tAbcIcz6BMO@kspp/ > > drivers/firewire/core-cdev.c | 42 ++++++++++++++++-------------------- > 1 file changed, 19 insertions(+), 23 deletions(-) Applied to for-next branch. Thanks Takashi Sakamoto