Re: [PATCH v1] tools: Fix compile error of pfrut/firewire

在 2025/3/29 09:07, Takashi Sakamoto 写道:
> Hi,
> 
> On Fri, Mar 28, 2025 at 03:47:50PM +0800, Riwen Lu wrote:
>> The value -rR of MAKEFLAGS implicit do not use make's built-in rules and
>> variables. Previous commit d1d096312176 ("tools: fix annoying "mkdir -p
>> ..." logs when building tools in parallel") removed the MAKEFLAGS=
>> command for tools and caused the built-in rules for pfrut/firewire
>> failed to take effect.
>>
>> Reported-by: k2ci <[email protected]>
>> Signed-off-by: Riwen Lu <[email protected]>
>> ---
>>   tools/firewire/Makefile               | 7 +++++++
>>   tools/power/acpi/tools/pfrut/Makefile | 2 +-
>>   2 files changed, 8 insertions(+), 1 deletion(-)
> 
> As long as testing with v6.14 release, I can not find such failure. I
> guess that some one has fixed the issue between the commit and the
> release.
> 
> Would you please recheck the issue?
> 
> 
> Thanks
> 
> Takashi Sakamoto

I have reconfirmed that this type of error does indeed exist when using 
make tools/all or make tools/firewire at commit 4e82c87058f4 ("Merge tag 
'rust-6.15' of 
git://git.kernel.org/pub/scm/linux/kernel/git/ojeda/linux") in the 6.14 
kernel.
The relevant error messages are as follows:
$ make tools/all
   ...
   LD       pfrut
/usr/bin/ld: 
/home/luriwen/workspace/kernel/kernel.org/linux-git/linux/tools/power/acpi/tools/pfrut/pfrut.o: 
in function `print_cap':
/home/luriwen/workspace/kernel/kernel.org/linux-git/linux/tools/power/acpi/tools/pfrut/pfrut.c:179: 
undefined reference to `uuid_unparse'
/usr/bin/ld: 
/home/luriwen/workspace/kernel/kernel.org/linux-git/linux/tools/power/acpi/tools/pfrut/pfrut.c:184: 
undefined reference to `uuid_unparse'
/usr/bin/ld: 
/home/luriwen/workspace/kernel/kernel.org/linux-git/linux/tools/power/acpi/tools/pfrut/pfrut.c:189: 
undefined reference to `uuid_unparse'
/usr/bin/ld: 
/home/luriwen/workspace/kernel/kernel.org/linux-git/linux/tools/power/acpi/tools/pfrut/pfrut.c:191: 
undefined reference to `uuid_unparse'
collect2: error: ld returned 1 exit status

$ make tools/firewire
   SYNC    include/config/auto.conf.cmd
   HOSTCC  scripts/basic/fixdep
   HOSTCC  scripts/kconfig/conf.o
   HOSTCC  scripts/kconfig/confdata.o
   HOSTCC  scripts/kconfig/expr.o
   LEX     scripts/kconfig/lexer.lex.c
   YACC    scripts/kconfig/parser.tab.[ch]
   HOSTCC  scripts/kconfig/lexer.lex.o
   HOSTCC  scripts/kconfig/menu.o
   HOSTCC  scripts/kconfig/parser.tab.o
   HOSTCC  scripts/kconfig/preprocess.o
   HOSTCC  scripts/kconfig/symbol.o
   HOSTCC  scripts/kconfig/util.o
   HOSTLD  scripts/kconfig/conf
   DESCEND firewire
make[3]: *** No rule to make target 'nosy-dump.o', needed by 
'nosy-dump'.  Stop.
make[2]: *** [Makefile:72: firewire] Error 2
make[1]: *** 
[/home/kylin/remote/kernel/kernel.org/linux-git/linux/Makefile:1438: 
tools/firewire] Error 2
make: *** [Makefile:251: __sub-make] Error 2

Thanks