[PATCH] firewire: ohci: Initialize payload_bus to avoid uninitialized use warning
Purva Yeshi <[email protected]> Thu, 10 Jul 2025 13:09:06 +0530
| Newsgroups | gmane.linux.kernel,gmane.linux.kernel.firewire.devel |
|---|---|
| Message-ID | <[email protected]> |
Fix Smatch-detected error: drivers/firewire/ohci.c:1514 at_context_queue_packet() error: uninitialized symbol 'payload_bus'. Smatch reports a potential uninitialized use of 'payload_bus' in at_context_queue_packet(). If packet->payload_length is zero, the variable may not be set before reaching the dma_unmap_single() call, which could lead to undefined behavior. Initialize 'payload_bus' to 0 to ensure it has a defined value in all code paths, preventing any uninitialized access. Signed-off-by: Purva Yeshi <[email protected]> --- drivers/firewire/ohci.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/firewire/ohci.c b/drivers/firewire/ohci.c index edaedd156a6d..c05d90511f2b 100644 --- a/drivers/firewire/ohci.c +++ b/drivers/firewire/ohci.c @@ -1392,7 +1392,7 @@ static int at_context_queue_packet(struct context *ctx, struct fw_packet *packet) { struct fw_ohci *ohci = ctx->ohci; - dma_addr_t d_bus, payload_bus; + dma_addr_t d_bus, payload_bus = 0; struct driver_data *driver_data; struct descriptor *d, *last; __le32 *header; -- 2.34.1