Re: [PATCH 00/11] firewire: code refactoring mainly for bm_work

On Mon, Sep 08, 2025 at 10:20:57AM +0900, Takashi Sakamoto wrote:
> Hi,
> 
> The core function in this subsystem have bm_work work item. The
> corresponding function has many lines with comments. It is a sign
> that it is time to be refactored, in my experience.
> 
> This series includes the first take for the purpose, as well as the
> other code improvements of 1394 OHCI PCI driver and the other core
> functions.
> 
> Takashi Sakamoto (11):
>   firewire: ohci: use kcalloc() variant for array allocation
>   firewire: core: utilize cleanup function to release workqueue in error
>     path
>   firewire: ohci: use return value from fw_node_get()
>   firewire: core: add helper functions to access to fw_device data in
>     fw_node structure
>   firewire: core: use cleanup function in bm_work
>   firewire: ohci: localize transaction data and rcode per condition
>     branch
>   firewire: core: code refactoring to evaluate transaction result to
>     CSR_BUS_MANAGER_ID
>   firewire: core: refer fw_card member to initiate bus reset under
>     acquiring lock
>   firewire: core: code refactoring to detect both IEEE 1394:1995 IRM and
>     Canon MV5i
>   firewire: core: code refactoring to investigate root node for bus
>     manager
>   firewire: core: code refactoring whether root node is cycle master
>     capable
> 
>  drivers/firewire/core-card.c   | 239 +++++++++++++++++----------------
>  drivers/firewire/core-device.c |  18 +--
>  drivers/firewire/core.h        |  14 +-
>  drivers/firewire/ohci.c        |   7 +-
>  4 files changed, 143 insertions(+), 135 deletions(-)

Applied to for-next branch.


Regards

Takashi Sakamoto