Re: [PATCH] firewire: core: remove useless lockdep_assert_held()

Takashi Sakamoto <[email protected]> Sat, 13 Sep 2025 19:51:23 +0900
Newsgroups gmane.linux.kernel,gmane.linux.kernel.firewire.devel
Message-ID <[email protected]>
On Fri, Sep 12, 2025 at 07:13:11AM +0900, Takashi Sakamoto wrote:
> The bm_work work item should be scheduled after holding fw_card reference
> counting. At a commit 25feb1a96e21 ("firewire: core: use cleanup function
> in bm_work"), I misinterpreted it as fw_card spinlock and inserted
> lockdep_assert_hold() wrongly.
> 
> This commit removes the useless line.
> 
> Fixes: 25feb1a96e21 ("firewire: core: use cleanup function in bm_work")
> Signed-off-by: Takashi Sakamoto <[email protected]>
> ---
>  drivers/firewire/core-card.c | 2 --
>  1 file changed, 2 deletions(-)

Applied to for-next branch.


Regards

Takashi Sakamoto