Re: firewire-ohci: 7.0.0-rc1 warnings+crash

On 2026-02-28, Takashi Sakamoto <[email protected]> wrote:
> Thanks for the issue. It reports that the page array passed to vmap()
> includes any entries which have invalid PFN. I realize that the page
> array is passed to page_alloc_bulk() without zero initialization, thus
> it could include any garbage values.
>
> Would I ask you to apply the following patch and the issue is still
> regenerated or not?

With the patch applied, everything is working again. Thanks!

> ===== 8<- -----
> From 0d82ddae99869b231200d5247bbae586bf28274c Mon Sep 17 00:00:00 2001
> From: Takashi Sakamoto <[email protected]>
> Date: Sat, 28 Feb 2026 11:56:03 +0900
> Subject: [PATCH] firewire: ohci: initialize page array to use
>  alloc_pages_bulk() correctly
>
> The call of alloc_pages_bulk() skips to fill entries of page array when
> the entries already have values. While, 1394 OHCI PCI driver passes the
> page array without initializing. It could cause invalid state at PFN
> validation in vmap().
>
> Fixes: f2ae92780ab9 ("firewire: ohci: split page allocation from dma mapping")
> Reported-by: John Ogness <[email protected]>
> Closes: https://lore.kernel.org/lkml/[email protected]/
> Signed-off-by: Takashi Sakamoto <[email protected]>

Tested-by: John Ogness <[email protected]>