Re: [PATCH v3 0/2] firewire: core: validate descriptor and sub-block lengths in fw_core_add_descriptor()
Sreeraj S Kurup <[email protected]> Mon, 27 Jul 2026 17:42:31 +0000
| Newsgroups | gmane.linux.kernel,gmane.linux.kernel.firewire.devel |
|---|---|
| Message-ID | <[email protected]> |
Hi Takashi, Thanks for applying the series to the for-next branch! Regarding the change in generate_config_rom(): I dropped that specific change from this patchset to keep the series strictly focused on the out-of-bounds issue in fw_core_add_descriptor(). `WARN_ON(j != config_rom_length)` acts as an assertion that the ROM block traversal matched the expected length. Replacing it with pr_warn() and clamping `config_rom_length = j` avoids a kernel warning splat, but if j != config_rom_length occurs, it indicates an unexpected state during ROM generation rather than a standard runtime condition. If you feel handling length mismatches gracefully via pr_warn() and updating config_rom_length is preferred over the WARN_ON assertion, I would be happy to send a follow-up patch for it. Thanks, Sreeraj