Re: [bug report] ovpn: implement packet processing

On Wed, May 13, 2026 at 10:41:40AM +0200, Antonio Quartulli wrote:
> Hello Dan,
> 
> On 12/05/2026 10:45, Dan Carpenter wrote:
> > Hello Antonio Quartulli,
> > 
> > Commit 8534731dbf2d ("ovpn: implement packet processing") from Apr
> > 15, 2025 (linux-next), leads to the following Smatch static checker
> > warning:
> > 
> > drivers/net/ovpn/io.c:207 ovpn_decrypt_post() warn: variable dereferenced before check 'peer' (see line 148)
> > drivers/net/ovpn/io.c:305 ovpn_encrypt_post() warn: variable dereferenced before check 'peer' (see line 304)
> > 
> 
> Thanks for this report.
> It is valid and I will indeed remove the NULL checks.
> 
> What/who should I credit in the Reported-by tag?
> 
> On a side note: from time to time I also run smatch on the ovpn code, but I
> haven't caught these ones. Any clue?

I'm doing a big re-write so there are a lot of new warnings (mostly false
ositives from me breaking things).  It's going to be some weeks before I
can patch it up enough to publish.

regards,
dan carpenter