Re: [PATCH] firmware: stratix10-rsu: Fix NULL deref on rsu_send_msg() timeout in probe

Markus Elfring <[email protected]>
Newsgroups gmane.linux.kernel.janitors,gmane.linux.kernel.stable,gmane.linux.kernel
Message-ID <[email protected]> 
…
> Apply the same cleanup pattern to the remaining failure paths: remove the
> async client, free the channel, and return early so no further messages are
> queued on a channel whose scl has been cleared.
…

How do you think about to avoid a bit of duplicate source code
in the implementation of the function “stratix10_rsu_probe”?
https://elixir.bootlin.com/linux/v7.1-rc4/source/drivers/firmware/stratix10-rsu.c#L715-L807

https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/coding-style.rst?h=v7.1-rc4#n526

Regards,
Markus
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.