Re: [PATCH][next] iio: adc: make read-only const array config static
Andy Shevchenko <[email protected]> Tue, 14 Jul 2026 20:08:10 +0300
| Newsgroups | gmane.linux.kernel.iio,gmane.linux.kernel.janitors,gmane.linux.kernel |
|---|---|
| Organization | Intel Finland Oy - BIC 0357606-4 - c/o Alberga Business Park, 6 krs, Bertel Jungin Aukio 5, 02600 Espoo |
| Message-ID | <[email protected]> |
On Tue, Jul 14, 2026 at 05:50:12PM +0100, Colin Ian King wrote: > Don't populate the read-only const array config on the stack at run > time, instead make it static. Reviewed-by: Andy Shevchenko <[email protected]> ... In all patches like this it's always a bikeshedding possible of moving static data outside of a function. I have no strong opinion in these cases (when the data solely used by a single function), but in general it might give different readability experience (it's harder to notice static data in the local function definition block). So I leave this exercise to the maintainers of the respective pieces of the code. -- With Best Regards, Andy Shevchenko