Re: [v2 net-next] net: rnpgbe: Delete a null pointer check in rnpgbe_rm_adapter()
Markus Elfring <[email protected]> Fri, 17 Jul 2026 08:10:01 +0200
| Newsgroups | gmane.linux.network,gmane.linux.kernel.janitors,gmane.linux.kernel |
|---|---|
| Message-ID | <[email protected]> |
>> The check for the pointer =E2=80=9Cmucse=E2=80=9D was finally identifie= d as undesirable. > I'm not sure finally is appropriate. It was one of the first questions > i asked. Also, i expect anybody looking at a Coccinelle report to take > the time to understand the code and decide what the correct fix is. We > have too many developers doing the minimum to make the tool happy, > without actually thinking. >=20 > Please also include the reasoning behind this. The commit message is > all about "Why?" Why is it undesirable? Why could a redundant sanity check be tolerated for a while? Regards, Markus