Re: [cocci] [1/36] coccinelle: misc: add cond_return_no_effect.cocci

Markus Elfring <[email protected]> Fri, 24 Jul 2026 17:32:12 +0200
Newsgroups gmane.linux.kernel,gmane.linux.kernel.janitors
Message-ID <[email protected]>
>> =E2=80=A6
>>> +++ b/scripts/coccinelle/misc/cond_return_no_effect.cocci
=E2=80=A6
> Combining them with two separate metavariables would be okay,

Thanks that you can think a bit more about such a design variant.


>                                                               but I
> don't see much benefit in that change.

Further metavariables can eventually be shared for an SmPL rule.

How do you think about to avoid repeated search efforts by separate SmPL r=
ules
(for the patch mode)?


>                                        So I'd prefer to stay existing
> form.
There are different SmPL coding style preferences involved.

Regards,
Markus