Re: [v2 2/2] soc: fsl: dpio: Use scope-based resource management in dpaa2_io_create()

Markus Elfring <[email protected]> Mon, 27 Jul 2026 15:14:54 +0200
Newsgroups gmane.linux.ports.ppc.embedded,gmane.linux.ports.arm.kernel,gmane.linux.kernel,gmane.linux.kernel.janitors
Message-ID <[email protected]>
>> Scope-based resource management became supported for some
>> programming interfaces by contributions of Peter Zijlstra on 2023-05-26=
.
>> See also the commit 54da6a0924311c7cf5015533991e44fb8eb12773 ("locking:
>> Introduce __cleanup() based infrastructure").
>>
>> * Thus use the attribute =E2=80=9C__free(kfree)=E2=80=9D.
>>
>> * Omit two kfree() calls accordingly.
>>
>> * Reduce the scopes for the local variables =E2=80=9Cobj=E2=80=9D
>>   and =E2=80=9Cqman_256_cycles_per_ns=E2=80=9D.
>=20
> Remove these changes. All variables should be defined at the start of
> the function, especially since there is no strong reason not to.
Can such a feedback be also interpreted in the way that you have got still=
 difficulties
with complete support of scope-based resource management?

Regards,
Markus