Re: [PATCH] USB: OHCI: drop unneeded semicolon
Alan Stern <[email protected]> Sat, 1 Aug 2026 19:53:27 -0400
| Newsgroups | gmane.linux.kernel,gmane.linux.kernel.janitors,gmane.linux.usb.general |
|---|---|
| Message-ID | <[email protected]> |
On Sat, Aug 01, 2026 at 09:09:47PM +0200, Julia Lawall wrote:
> When a function-like macro expands to an expression, that expression
> doesn't need a semicolon after it. All uses have been verified to
> have their own semicolons.
>
> This was found using the following Coccinelle semantic patch:
>
> @r@
> identifier i : script:ocaml() { String.lowercase_ascii i = i };
> expression e;
> @@
>
> *#define i(...) e;
>
> Signed-off-by: Julia Lawall <[email protected]>
>
> ---
Reviewed-by: Alan Stern <[email protected]>
> drivers/usb/host/ohci-dbg.c | 2 +-
> drivers/usb/host/ohci-hub.c | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/usb/host/ohci-dbg.c b/drivers/usb/host/ohci-dbg.c
> index 9e0e06bbc..4c83a1686 100644
> --- a/drivers/usb/host/ohci-dbg.c
> +++ b/drivers/usb/host/ohci-dbg.c
> @@ -184,7 +184,7 @@ ohci_dump_status (struct ohci_hcd *controller, char **next, unsigned *size)
> \
> (temp & RH_PS_PES) ? " PES" : "", \
> (temp & RH_PS_CCS) ? " CCS" : "" \
> - );
> + )
>
>
> static void
> diff --git a/drivers/usb/host/ohci-hub.c b/drivers/usb/host/ohci-hub.c
> index b3d734ab6..84d10a932 100644
> --- a/drivers/usb/host/ohci-hub.c
> +++ b/drivers/usb/host/ohci-hub.c
> @@ -33,7 +33,7 @@
> \
> (value & RH_PS_PES) ? " PES" : "", \
> (value & RH_PS_CCS) ? " CCS" : "" \
> - );
> + )
>
> /*-------------------------------------------------------------------------*/
>
>