Re: [cocci] [PATCH] coccinelle: scripts: coccinelle: devm_free: reduce false positives

Markus Elfring <[email protected]>
Newsgroups gmane.linux.kernel.janitors,gmane.linux.kernel
Message-ID <[email protected]>
>>> False positives could be introduced due to allocations using the new
>>> _obj functions.  Add these to the "safe" rule accordingly.
>>
>> Can the SmPL disjunction specification be refined another bit?
> 
> As usual, a random comment with no context that makes the reader have to
> go look up some other information to have any idea what you are talking
> about.

How hard is it to determine technical details for a running patch review?


> Anyway, since I did take several minutes to go find the file and look at
> it,

You propose to adjust some SmPL code.


>     I guess you want the disjunctions to be ordered by frequency in the
> code base.

I imagine that such a design possibility can become helpful.


>             But I'm not going to do that.

I assume that further contributors would occasionally like to benefit
more from nicer run time characteristics also for Coccinelle software.
https://en.wikipedia.org/wiki/Short-circuit_evaluation

Can SmPL code become a bit more succinct accordingly?

Regards,
Markus
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.