Re: [PATCH] thermal/drivers/imx9: Constify struct thermal_zone_device_ops
Frank Li <[email protected]>
| Newsgroups | gmane.linux.kernel.janitors,gmane.linux.kernel,gmane.linux.power-management.general,gmane.linux.ports.arm.kernel |
|---|---|
| Message-ID | <anoh9t4oqR7XhS74@SMW015318> |
On Sat, Aug 08, 2026 at 10:23:33PM +0200, Christophe JAILLET wrote: > 'struct thermal_zone_device_ops' is not modified in this driver. > > Constifying this structure moves some data to a read-only section, so > increases overall security, especially when the structure holds some > function pointers. > > On a x86_64, with allmodconfig: > Before: > ====== > text data bss dec hex filename > 8567 2144 0 10711 29d7 drivers/thermal/imx91_thermal.o > > After: > ===== > text data bss dec hex filename > 8695 2016 0 10711 29d7 drivers/thermal/imx91_thermal.o > > Signed-off-by: Christophe JAILLET <[email protected]> > --- Reviewed-by: Frank Li <[email protected]> > Compile tested only. > --- > drivers/thermal/imx91_thermal.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/thermal/imx91_thermal.c b/drivers/thermal/imx91_thermal.c > index 25915bb702be..892a25440e06 100644 > --- a/drivers/thermal/imx91_thermal.c > +++ b/drivers/thermal/imx91_thermal.c > @@ -225,7 +225,7 @@ static int imx91_tmu_change_mode(struct thermal_zone_device *tz, enum thermal_de > return 0; > } > > -static struct thermal_zone_device_ops tmu_tz_ops = { > +static const struct thermal_zone_device_ops tmu_tz_ops = { > .get_temp = imx91_tmu_get_temp, > .change_mode = imx91_tmu_change_mode, > .set_trips = imx91_tmu_set_trips, > -- > 2.55.0 > >