Re: [PATCH] drm/virtio: Fix a NULL vs ERR_PTR() bug in virtio_gpu_user_framebuffer_create()
Dmitry Osipenko <[email protected]>
| Newsgroups | gmane.linux.kernel.virtualization,gmane.comp.video.dri.devel,gmane.linux.kernel,gmane.linux.kernel.janitors |
|---|---|
| Message-ID | <[email protected]> |
On 8/13/26 10:08, Dan Carpenter wrote:
> Smatch complains that returning a NULL here will lead to a NULL pointer
> dereference in drm_mode_addfb2(). Return an error pointer instead.
>
> Fixes: dc5698e80cf7 ("Add virtio gpu driver.")
> Signed-off-by: Dan Carpenter <[email protected]>
> ---
> This code is obviously over a decade old. I think this patch is correct.
> None of the other implementations return NULL, but I haven't tested it.
> ---
> drivers/gpu/drm/virtio/virtgpu_display.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/virtio/virtgpu_display.c b/drivers/gpu/drm/virtio/virtgpu_display.c
> index 44ffffec550f..85ea252c658e 100644
> --- a/drivers/gpu/drm/virtio/virtgpu_display.c
> +++ b/drivers/gpu/drm/virtio/virtgpu_display.c
> @@ -344,7 +344,7 @@ virtio_gpu_user_framebuffer_create(struct drm_device *dev,
> if (ret) {
> kfree(virtio_gpu_fb);
> drm_gem_object_put(obj);
> - return NULL;
> + return ERR_PTR(ret);
> }
>
> return &virtio_gpu_fb->base;
Applied to drm-misc-fixes, thanks!
--
Best regards,
Dmitry