Re: [cocci] [v3] coccinelle: Detect clk_register() anti-pattern
Markus Elfring <[email protected]>
| Newsgroups | gmane.linux.kernel.clk,gmane.linux.kernel,gmane.linux.kernel.janitors |
|---|---|
| Message-ID | <[email protected]> |
… >> another issue is that in one case, removing the error message leaves: >> >> ret = PTR_ERR(inno->phyclk); >> return ret; >> >> This could be cleaned up to just return PTR_ERR(inno->phyclk) > Note that there are lots of occurrences of > > ret = e; > return ret; > > for some expression ret and e, and 99.99% of them are fine as is. But in > this specific case of error handling code, perhaps it is not useful to > introduce more of them. Will such a development concern trigger further collateral evolution for desirable source code transformation approaches? Regards, Markus