Re: [PATCH] fbdev: platinumfb: add error checking for ioremap calls
Markus Elfring <[email protected]>
| Newsgroups | gmane.linux.kernel.janitors,gmane.comp.video.dri.devel,gmane.linux.kernel |
|---|---|
| Message-ID | <[email protected]> |
… > Add proper error checking and cleanup for all three ioremap calls in > the probe function, ensuring that any resources already allocated are > properly released on failure. * Please avoid duplicate source code also in the implementation of the function “platinumfb_probe”. https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/coding-style.rst?h=v7.2-rc7#n526 * How do you think about to increase the application of scope-based resource management? * Would you like to add any tags (like “Fixes” and “Cc”) accordingly? https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v7.2-rc7#n145 https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/stable-kernel-rules.rst?h=v7.2-rc7#n34 Regards, Markus